(feat) O3-2971: Show a confirmation modal when the user submits an empty form #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UNCANNY69
changed the title
|
I made many changes to the form-factory-provider , I would like it to be reviewed in case it can be designed better @NethmiRodrigo @samuelmale @denniskigen |
NethmiRodrigo
requested review from
samuelmale,
denniskigen and
NethmiRodrigo
samuelmale
reviewed
Feb 10, 2025
denniskigen
reviewed
Feb 10, 2025
3 tasks
|
Reated PR: |
|
I made the changes according to the discussion in the JIRA, can it be reviewed again @denniskigen @samuelmale @NethmiRodrigo |
samuelmale
reviewed
Feb 12, 2025
samuelmale
reviewed
Feb 13, 2025
vasharma05
reviewed
Apr 21, 2025
samuelmale
reviewed
Apr 22, 2025
samuelmale
reviewed
Apr 24, 2025
|
Resolved all the comments can it be reviewed again @denniskigen @samuelmale ? |
denniskigen
changed the title
samuelmale
reviewed
May 19, 2025
| const result = handleEmptyFormSubmission(); | ||
| if (result instanceof Promise) { | ||
| try { | ||
| await result; |
There was a problem hiding this comment.
Shouldn't we try inferring the resolved promise to a boolean?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR adds a feature which triggers a conformation modal when User submits an empty form.
Screenshots
OpenMRS.-.Google.Chrome.2025-02-11.23-09-36.mp4
Related Issue
Other